feat: add preview with no window picker action #2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umlx5h
force-pushed
the
add_preview_with_no_picker
branch
from
f52f8ad to
5f48779
Compare
I like that. Updating the API to match. |
alex-courtis
approved these changes
Oct 15, 2023
| @@ -171,16 +171,6 @@ local function open_or_expand_or_dir_up(mode) | |||
| end | |||
| end | |||
|
|
|||
| local function open_preview(node) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I often use preview feature, But if there is more than one window, It always prompts picker selection menu.
But I don't want to disable picker feature entirely.
I think that the option to not use the picker should be provided in preview as well, since it is the same kind of functionality as 'Open'.
When I set 'Open Preview: No Window Picker' to match 'Open: No Window Picker', the help message became too long horizontally.
So I chose 'Open Preview: No Picker'.
Feel free to change the name if you like.
I ran this script and githooks.
no indent diff
https://github.com/nvim-tree/nvim-tree.lua/pull/2464/files?w=1